osmo-bsc[master]: cosmetic: use fsm pointer from parameter list

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 24 16:31:36 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/4985/2/src/osmo-bsc/osmo_bsc_mgcp.c
File src/osmo-bsc/osmo_bsc_mgcp.c:

Line 188: 	LOGPFSML(fi, LOGL_DEBUG, "fsm-state: %s, fsm-event: %s\n",
I'm getting annoyed by these LOGPFSM of FSM state and event, which are *clearly* logged by the FSM code already, and I've said so at least thrice now. Same below. Drop these. Ok, maybe in a separate patch.


-- 
To view, visit https://gerrit.osmocom.org/4985
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ff62e7e2de64c2dbf5ea2736f5e58faf16df0b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list