osmo-mgw[master]: vty: do not change number_endpoints at runtime

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 24 12:42:26 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/4779/3/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:

Line 1296: 	g_cfg->trunk.number_endpoints = g_cfg->trunk.vty_number_endpoints;
> -1: rather assign the number of allocated endpoints only after allocation, 
hmm ok, I see the mgcp_endpoints_allocate() kind of uses the number_endpoints as argument. Technically the cleanest approach would be to change the API to pass the number that should be allocated as argument to the function, but in terms of least code change you could also set number_endpoints = 0 in case of error.


-- 
To view, visit https://gerrit.osmocom.org/4779
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3994af016fb96427263edbba05f560743f85fdd4
Gerrit-PatchSet: 3
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list