[PATCH] libosmocore[master]: Deprecate old counter functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Nov 23 18:31:29 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5015

to look at the new patch set (#2).

Deprecate old counter functions

Their functionality is superceeded by rate_ctr.abs facility.

Change-Id: I604ee50b175751f5cc9416cdca1f29c355273312
---
M include/osmocom/core/counter.h
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/5015/2

diff --git a/include/osmocom/core/counter.h b/include/osmocom/core/counter.h
index e692f7e..12fa0ce 100644
--- a/include/osmocom/core/counter.h
+++ b/include/osmocom/core/counter.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include <osmocom/core/defs.h>
+
 /*! \file counter.h
  *  Common routines regarding counter handling */
 
@@ -38,12 +40,12 @@
 	ctr->value = 0;
 }
 
-struct osmo_counter *osmo_counter_alloc(const char *name);
+struct osmo_counter *osmo_counter_alloc(const char *name) OSMO_DEPRECATED("Use rate_ctr.h instead");
 
-void osmo_counter_free(struct osmo_counter *ctr);
+void osmo_counter_free(struct osmo_counter *ctr) OSMO_DEPRECATED("Use rate_ctr.h instead");
 
-int osmo_counters_for_each(int (*handle_counter)(struct osmo_counter *, void *), void *data);
+int osmo_counters_for_each(int (*handle_counter)(struct osmo_counter *, void *), void *data) OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE;
 
-struct osmo_counter *osmo_counter_get_by_name(const char *name);
+struct osmo_counter *osmo_counter_get_by_name(const char *name) OSMO_DEPRECATED("Use rate_ctr.h instead");
 
-int osmo_counter_difference(struct osmo_counter *ctr);
+int osmo_counter_difference(struct osmo_counter *ctr) OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE;

-- 
To view, visit https://gerrit.osmocom.org/5015
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I604ee50b175751f5cc9416cdca1f29c355273312
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list