[PATCH] osmo-bsc[master]: cosmetic: do not cast void pointer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Nov 23 13:44:38 UTC 2017


Review at  https://gerrit.osmocom.org/4984

cosmetic: do not cast void pointer

remove the casting of void *data, just assign directly

Change-Id: I2e37630e315b3602da2f14e2364bb76be9dd2894
---
M src/osmo-bsc/osmo_bsc_mgcp.c
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/4984/1

diff --git a/src/osmo-bsc/osmo_bsc_mgcp.c b/src/osmo-bsc/osmo_bsc_mgcp.c
index 8d55d18..1bc4c42 100644
--- a/src/osmo-bsc/osmo_bsc_mgcp.c
+++ b/src/osmo-bsc/osmo_bsc_mgcp.c
@@ -171,7 +171,7 @@
 /* Callback for ST_CRCX_BTS: startup state machine send out CRCX for BTS side */
 static void fsm_crcx_bts_cb(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
-	struct mgcp_ctx *mgcp_ctx = (struct mgcp_ctx *)data;
+	struct mgcp_ctx *mgcp_ctx = data;
 	struct osmo_bsc_sccp_con *conn;
 	struct msgb *msg;
 	struct mgcp_msg mgcp_msg;
@@ -272,7 +272,7 @@
  * with the assignment request */
 static void fsm_proc_assignmnent_req_cb(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
-	struct mgcp_ctx *mgcp_ctx = (struct mgcp_ctx *)data;
+	struct mgcp_ctx *mgcp_ctx = data;
 	struct osmo_bsc_sccp_con *conn;
 	enum gsm48_chan_mode chan_mode;
 	bool full_rate;
@@ -315,7 +315,7 @@
  * proceed with updating the connection for the BTS side */
 static void fsm_mdcx_bts_cb(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
-	struct mgcp_ctx *mgcp_ctx = (struct mgcp_ctx *)data;
+	struct mgcp_ctx *mgcp_ctx = data;
 	struct osmo_bsc_sccp_con *conn;
 	struct gsm_lchan *lchan;
 	struct msgb *msg;
@@ -435,7 +435,7 @@
 /* Callback for ST_CRCX_NET: An mgcp response has been received, proceed... */
 static void fsm_crcx_net_cb(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
-	struct mgcp_ctx *mgcp_ctx = (struct mgcp_ctx *)data;
+	struct mgcp_ctx *mgcp_ctx = data;
 	struct osmo_bsc_sccp_con *conn;
 	struct msgb *msg;
 	struct mgcp_msg mgcp_msg;
@@ -571,7 +571,7 @@
 /* Callback for ST_ASSIGN_COMPL: Send back assignment complete and wait until the call ends */
 static void fsm_send_assignment_complete(struct osmo_fsm_inst *fi, uint32_t event, void *data)
 {
-	struct mgcp_ctx *mgcp_ctx = (struct mgcp_ctx *)data;
+	struct mgcp_ctx *mgcp_ctx = data;
 	struct gsm_lchan *lchan;
 
 	OSMO_ASSERT(mgcp_ctx);

-- 
To view, visit https://gerrit.osmocom.org/4984
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e37630e315b3602da2f14e2364bb76be9dd2894
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list