This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/4971 cosmetic: log error when using a conn that's in release If a conn is attempted to be used when in release, log an error, but don't skip tracking. No current code path apparently hits this, according to msc_vlr_tests. Just making sure that we will prominently see such errors when we introduce any. Change-Id: I8dd20ee56ce5ad7a90fcd03a06604c383e5eed54 --- M src/libmsc/osmo_msc.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/4971/1 diff --git a/src/libmsc/osmo_msc.c b/src/libmsc/osmo_msc.c index f807f2a..42acf79 100644 --- a/src/libmsc/osmo_msc.c +++ b/src/libmsc/osmo_msc.c @@ -348,7 +348,10 @@ OSMO_ASSERT(conn); if (conn->in_release) - return NULL; + LOGPSRC(DREF, LOGL_ERROR, file, line, + "%s: MSC conn use error: using conn that is already in release (%s)\n", + vlr_subscr_name(conn->vsub), + msc_subscr_conn_use_name(balance_token)); conn->use_count++; LOGPSRC(DREF, LOGL_DEBUG, file, line, -- To view, visit https://gerrit.osmocom.org/4971 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8dd20ee56ce5ad7a90fcd03a06604c383e5eed54 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>