[PATCH] osmo-bsc[master]: bsc_init: fix Werror: define rc for 2quater with si2q_count ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 21 13:42:55 UTC 2017


Review at  https://gerrit.osmocom.org/4949

bsc_init: fix Werror: define rc for 2quater with si2q_count == 0

  src/libbsc/bsc_init.c: In function ‘rsl_si’:
  src/libbsc/bsc_init.c:153:2: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    return rc;
    ^

Change-Id: Iedad1efcb477c77db8c741777ea076761658c7d1
---
M src/libbsc/bsc_init.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/4949/1

diff --git a/src/libbsc/bsc_init.c b/src/libbsc/bsc_init.c
index 674813c..fa8c477 100644
--- a/src/libbsc/bsc_init.c
+++ b/src/libbsc/bsc_init.c
@@ -142,6 +142,7 @@
 			rc = rsl_bcch_info(trx, i, NULL, 0);
 			break;
 		}
+		rc = 0;
 		for (j = 0; j <= bts->si2q_count; j++)
 			rc = rsl_bcch_info(trx, i, (const uint8_t *)GSM_BTS_SI2Q(bts, j), GSM_MACBLOCK_LEN);
 		break;

-- 
To view, visit https://gerrit.osmocom.org/4949
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedad1efcb477c77db8c741777ea076761658c7d1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list