[MERGED] osmo-iuh[master]: api doc: clarify byte order in ranap_new_msg_rab_assign_*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 20 21:38:50 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: api doc: clarify byte order in ranap_new_msg_rab_assign_*
......................................................................


api doc: clarify byte order in ranap_new_msg_rab_assign_*

Change-Id: Ib0d2cc538488a995be5278092d3ac105be8aad33
---
M src/ranap_msg_factory.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index 64d87f9..ef3e9ef 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -716,7 +716,8 @@
 
 /*! \brief generate RANAP RAB ASSIGNMENT REQUEST message for CS (voice).
  * See 3GPP TS 25.413 8.2.
- * RAB ID: 3GPP TS 25.413 9.2.1.2
+ * RAB ID: 3GPP TS 25.413 9.2.1.2.
+ * \param rtp_ip  MGW's RTP IPv4 address in *network* byte order.
  */
 struct msgb *ranap_new_msg_rab_assign_voice(uint8_t rab_id, uint32_t rtp_ip,
 					    uint16_t rtp_port,
@@ -785,7 +786,8 @@
 	return msg;
 }
 
-/*! \brief generate RANAP RAB ASSIGNMENT REQUEST message for PS (data) */
+/*! \brief generate RANAP RAB ASSIGNMENT REQUEST message for PS (data)
+ * \param gtp_ip  SGSN's GTP IPv4 address in *network* byte order. */
 struct msgb *ranap_new_msg_rab_assign_data(uint8_t rab_id, uint32_t gtp_ip,
 					   uint32_t gtp_tei, bool use_x213_nsap)
 {

-- 
To view, visit https://gerrit.osmocom.org/4936
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0d2cc538488a995be5278092d3ac105be8aad33
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list