osmo-msc[master]: sub_pres_vlr_fsm_start: fix heap use after free

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 20 13:49:20 UTC 2017


Patch Set 1:

> It does look like the easiest way. So the general rule of thumb is
 > that after an event dispatch the object could be invalidated?

yep. That has caught me a number of times already.

Another way actually is to never dispatch events in the construction function of an FSM, but rather only return the FSM pointer, and require the caller to issue the start event separately.

 > Separate construction from event transition?

exactly. I've done so elsewhere (in libmsc/libvlr IIRC), but it does duplicate the event firing to all callers ... so ... yeah.

-- 
To view, visit https://gerrit.osmocom.org/4923
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdc0b64cd12ba3e2b9737e3517d8484e67abcf04
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list