osmo-msc[master]: cosmetic: msc_vlr_tests: add comment to show expected tallocs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 20 13:42:44 UTC 2017


Patch Set 1:

> How does this help you? If that is the expected put it into the .ok
 > file? Not following you here. :)

I'd have liked to put it in the .ok or .err files, but the talloc report contains memory addresses that aren't constant. Hence I only check the size and output the report if something is unexpected. At that point, there is no reference to compare to, hence the comment.

Would be nice to have a talloc report that is fully reproducible. Those addresses usually don't help much anyway.

-- 
To view, visit https://gerrit.osmocom.org/4927
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If92a18bb3dc24c2cf6498aa2da29266267488240
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list