This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4931/1/src/host/layer23/src/mobile/primitives.c
File src/host/layer23/src/mobile/primitives.c:
Line 104: struct mobile_started_prim prim = { 0, };
you're using the primitive header outside of the context of a msgb, which is not something that we have done so far, AFAIK/AFAIR. Once we introduce something like osmo_prim_free() this might become confusing? or we could simply have prim_hdr.msg=NULL in such cases to indicate it's not a msgb-wrapped primitive?
--
To view, visit https://gerrit.osmocom.org/4931
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df20a4ab79c06b515780675b6df2929aa976f0d
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes