This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4878/1/src/stream.c
File src/stream.c:
Line 433: while (1) {
why not simply "while (msg = msgb_dequeue()) talloc_free(msg)" ? two lines instead of 6, and as added benefit no "while (1)" which may ring some alarms by people looking at the code (just psychologically)
--
To view, visit https://gerrit.osmocom.org/4878
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaad35f03e3bdfabf3ba82b16e563c0a5d1f03639
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes