[PATCH] libosmo-sccp[master]: sccp_test: sanitize: fix msgb mem leaks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 17 02:34:18 UTC 2017


Review at  https://gerrit.osmocom.org/4880

sccp_test: sanitize: fix msgb mem leaks

Change-Id: I6d5ff3e4c053db5a2af9d548250f0307e00317bb
---
M tests/sccp/sccp_test.c
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/80/4880/1

diff --git a/tests/sccp/sccp_test.c b/tests/sccp/sccp_test.c
index 6043cff..d6abc5d 100644
--- a/tests/sccp/sccp_test.c
+++ b/tests/sccp/sccp_test.c
@@ -450,6 +450,7 @@
 	}
 
 	write_called = 1;
+	msgb_free(data);
 }
 
 void sccp_c_read(struct sccp_connection *connection, struct msgb *msgb, unsigned int len)
@@ -502,6 +503,7 @@
 	}
 
 	matched = 1;
+	msgb_free(data);
 }
 
 static void test_sccp_system(void)
@@ -981,6 +983,8 @@
 				osmo_hexdump(msg->data, ret));
 		}
 	}
+
+	talloc_free(msg);
 }
 
 static const struct log_info_cat default_categories[] = {

-- 
To view, visit https://gerrit.osmocom.org/4880
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d5ff3e4c053db5a2af9d548250f0307e00317bb
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list