This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/4863 lapd_test: sanitize: fix msgb memleaks Helps fix sanitizer build on debian 9. Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25 --- M tests/lapd/lapd_test.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/4863/1 diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c index d6c0495..fd92cac 100644 --- a/tests/lapd/lapd_test.c +++ b/tests/lapd/lapd_test.c @@ -498,6 +498,7 @@ rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); + msgb_free(pp.oph.msg); /* Send SABM MS 2, we must get nothing, due to collision */ cm2 = malloc(sizeof(cm)); @@ -513,6 +514,7 @@ rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); + msgb_free(pp.oph.msg); /* clean up */ lapdm_channel_exit(&bts_to_ms_channel); @@ -597,6 +599,7 @@ /* idempotent */ lapdm_channel_exit(&bts_to_ms_channel); + msgb_free(msg); } static void test_lapdm_establishment() @@ -702,6 +705,7 @@ rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0); + msgb_free(pp.oph.msg); printf("\nSending Classmark Change\n"); send_buf(cm_chg, sizeof(cm_chg), &bts_to_ms_channel); @@ -718,6 +722,7 @@ printf("\nSending GPRS Suspend Request\n"); send_buf(gprs_susp, sizeof(gprs_susp), &bts_to_ms_channel); dump_queue(&dl->dl.tx_queue); + msgb_free(pp.oph.msg); rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); @@ -726,10 +731,12 @@ printf("\nSending Cipher Mode Complete\n"); send_buf(cipher_compl, sizeof(cipher_compl), &bts_to_ms_channel); dump_queue(&dl->dl.tx_queue); + msgb_free(pp.oph.msg); rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); OSMO_ASSERT(memcmp(pp.oph.msg->l2h, cipher_compl_ack, ARRAY_SIZE(cipher_compl_ack)) == 0); + msgb_free(pp.oph.msg); printf("\nEstablishing SAPI=3\n"); send_sabm(&bts_to_ms_channel, 3, NULL, 0); @@ -738,6 +745,7 @@ rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_sms, ARRAY_SIZE(ua_sms)) == 0); + msgb_free(pp.oph.msg); printf("\nSending CP-DATA\n"); send_buf(cp_data_1, sizeof(cp_data_1), &bts_to_ms_channel); @@ -746,6 +754,7 @@ rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH"); CHECK_RC(rc); OSMO_ASSERT(memcmp(pp.oph.msg->l2h, cp_data_1_ack, ARRAY_SIZE(cp_data_1_ack)) == 0); + msgb_free(pp.oph.msg); /* clean up */ lapdm_channel_exit(&bts_to_ms_channel); -- To view, visit https://gerrit.osmocom.org/4863 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>