osmo-mgw[master]: MGCP endpoints: parse as decimal, not hex

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 14 09:11:26 UTC 2017


Patch Set 1:

> You notice that this has "always" been parsed as base 16? Sadly the
 > MGCP RFC doesn't say what an endpoint number should be. In the RFC
 > it is a "NameString" (some chars except /, $, *, 0-9 A-z). Sadly
 > the openbsc tests only check for single digit calls.

I think the real solution is https://osmocom.org/issues/2631
and moving to decimal parsing is just fixing the current behavior of osmo-bsc <-> osmo-mgw as a workaround for the time being. And realize that osmo-bsc *is* the only user of this code right now, anyone else is using osmo-bsc_mgcp which is not changing its behavior, since it's using libosmo-legacy-mgcp, while this is libosmo-mgcp.

-- 
To view, visit https://gerrit.osmocom.org/4780
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18608ff23303c1564548a86d5f6bfa539fe555e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list