[MERGED] osmo-hlr[master]: cosmetic: add comment on ignored return value

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: cosmetic: add comment on ignored return value
......................................................................


cosmetic: add comment on ignored return value

Coverity wants us to evaluate sqlite3_reset, but it is of no use to do so.

Related: coverity CID#178653
Change-Id: I64ac8c148f48be60f9c0d346df0c5152bb527494
---
M src/db.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/db.c b/src/db.c
index 8733cf5..d16f8ec 100644
--- a/src/db.c
+++ b/src/db.c
@@ -99,6 +99,8 @@
 void db_remove_reset(sqlite3_stmt *stmt)
 {
 	sqlite3_clear_bindings(stmt);
+	/* sqlite3_reset() just repeats an error code already evaluated during sqlite3_step(). */
+	/* coverity[CHECKED_RETURN] */
 	sqlite3_reset(stmt);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/4715
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64ac8c148f48be60f9c0d346df0c5152bb527494
Gerrit-PatchSet: 3
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder