osmo-bsc[master]: mgcp: use osmo-mgw to switch RTP streams

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Nov 10 06:44:54 UTC 2017


Patch Set 15:

(1 comment)

https://gerrit.osmocom.org/#/c/4334/15/src/osmo-bsc/osmo_bsc_mgcp.c
File src/osmo-bsc/osmo_bsc_mgcp.c:

Line 1012: 		return NULL;
One general high-level comment. All software will fail. Put yourself into the mindset it is 36C3, it is late, you are tired and handover/assignment is failing. All you got is the log file (and maybe a PCAP). From the 100 hundred concurrent calls some fail.

Is MGW_%d enough information to identify the trunk? Does it help you to identify the IMSI so you can find the packets in the PCAP file? Would you have significant information to build a mental model of what happens?

And I picked the line as it represents a silent failure (Unlikely it will be ever returning NULL here though).


-- 
To view, visit https://gerrit.osmocom.org/4334
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2882b7ca31a3219c676986e85045fa08a425d7a
Gerrit-PatchSet: 15
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list