[MERGED] libosmo-sccp[master]: ipa: Fix setting of OPC/DPC based on routing-context + override

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Nov 10 01:08:23 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: ipa: Fix setting of OPC/DPC based on routing-context + override
......................................................................


ipa: Fix setting of OPC/DPC based on routing-context + override

As IPA is a transport layer underneath SCCP, and we don't have MTP-level
OPC and DPC fields in it, we are using the "point-code override dpc"
feature for setting the pseudo-M3UA DPC on incoming Rx packets,
and we use the PC from the routing context as pseudo-M3UA OPC.

However, we were so far only storing this in the M3UA data header,
and not in the xua->mtp.{opc,dpc} members, which are consulted
during the routing decisions.

Change-Id: I5e2244620cd48f848382eb595ce59c6212069788
---
M src/ipa.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipa.c b/src/ipa.c
index a7060db..11ff422 100644
--- a/src/ipa.c
+++ b/src/ipa.c
@@ -179,6 +179,8 @@
 		data_hdr.dpc = as->cfg.routing_key.pc;
 	}
 	xua = m3ua_xfer_from_data(&data_hdr, msgb_l2(msg), msgb_l2len(msg));
+	xua->mtp.opc = data_hdr.opc;
+	xua->mtp.dpc = data_hdr.dpc;
 
 	return m3ua_hmdc_rx_from_l2(asp->inst, xua);
 }

-- 
To view, visit https://gerrit.osmocom.org/4753
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e2244620cd48f848382eb595ce59c6212069788
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list