This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has submitted this change and it was merged. Change subject: osmo-deps.sh: Force fetching git tags ...................................................................... osmo-deps.sh: Force fetching git tags It was recently spotted, in a osmo-msc jenkins build, that an updated dependency (new commits to be fetched) contained a new tag which was not fetched with the commit. It resulted in the Makefile generating an old .version file, which ended up generating a library version in the .pc which later in the build make the configure script fail while checking at the dependencies. As far as I could understand after reading several discussion threads, it seems git fetch doesn't necessarily fetch and store locally all new tags found in the remote, and we need to explicitly add the --tags parameter to be sure all of them are downloaded. This patch adds a new fetch line instead of patching the one already present because it seems in old versions of git the --tags parameter had a different behaviour, in which only tags and not branches are fetched. This way is ensured that we get both correct regardless of git version. Change-Id: I4bfe4846959c70e435d6792a755a6f2a6f0a932c --- M scripts/osmo-deps.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: lynxis lazus: Looks good to me, but someone else must approve Pau Espin Pedrol: Verified Neels Hofmeyr: Looks good to me, approved Harald Welte: Looks good to me, approved diff --git a/scripts/osmo-deps.sh b/scripts/osmo-deps.sh index d5a724b..a4afec5 100755 --- a/scripts/osmo-deps.sh +++ b/scripts/osmo-deps.sh @@ -9,6 +9,7 @@ fi cd "$project" +git fetch --tags origin git fetch origin # Cleanup should already have happened during a global osmo-clean-workspace.sh, -- To view, visit https://gerrit.osmocom.org/4718 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bfe4846959c70e435d6792a755a6f2a6f0a932c Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>