[MERGED] osmo-bsc[master]: fix build: bssap test broke by undefined references

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 8 00:02:17 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix build: bssap test broke by undefined references
......................................................................


fix build: bssap test broke by undefined references

After the bssap test in Ie934c5d229140a89763bf2efff86d6a3766cd351, the
subsequent commit Ia2882b7ca31a3219c676986e85045fa08a425d7a was not tested
against the latest head, and its breaking bssap_test was not caught.

Fix current master of osmo-bsc's 'make check' target: add osmo_bsc_mgcp.c and
libosmo-mgcp-client dependencies to bssap_test linkage.

Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
---
M tests/bssap/Makefile.am
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/bssap/Makefile.am b/tests/bssap/Makefile.am
index 80d655f..4bbe9ea 100644
--- a/tests/bssap/Makefile.am
+++ b/tests/bssap/Makefile.am
@@ -11,6 +11,7 @@
 	$(LIBOSMOABIS_CFLAGS) \
 	$(LIBOSMOSIGTRAN_CFLAGS) \
 	$(COVERAGE_CFLAGS) \
+	$(LIBOSMOMGCPCLIENT_CFLAGS) \
 	$(NULL)
 
 EXTRA_DIST = \
@@ -28,6 +29,7 @@
 	$(top_srcdir)/src/osmo-bsc/osmo_bsc_sigtran.c \
 	$(top_srcdir)/src/osmo-bsc/osmo_bsc_filter.c \
 	$(top_srcdir)/src/osmo-bsc/osmo_bsc_grace.c \
+	$(top_srcdir)/src/osmo-bsc/osmo_bsc_mgcp.c \
 	$(NULL)
 
 bssap_test_LDADD = \
@@ -39,6 +41,7 @@
 	$(LIBOSMOGSM_LIBS) \
 	$(LIBOSMOABIS_LIBS) \
 	$(LIBOSMOSIGTRAN_LIBS) \
+	$(LIBOSMOMGCPCLIENT_LIBS) \
 	$(NULL)
 
 bssap_test_LDFLAGS = \

-- 
To view, visit https://gerrit.osmocom.org/4721
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28719d267452f66d65581c43433e24a9f46cf7dc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list