osmo-pcu[master]: PCU: Fix TA adjustment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Nov 7 14:27:32 UTC 2017


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/4678/2/src/bts.cpp
File src/bts.cpp:

Line 1628: 	if (ta_delta) {
no change needed now/here, just general remark: Our usual coding style would be to exit early, i.e. "if (!ta_delta) return;" which saves us one level of indent.  Maybe good to follow for any future patches/changes. Don't waste time on it now.


-- 
To view, visit https://gerrit.osmocom.org/4678
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65212f8203f1a35278890f51db038d689b2493d5
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list