osmo-gsm-tester[master]: resource: Refactor next_msisdn to be more generic

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 7 00:07:02 UTC 2017


Patch Set 1: Code-Review-1

(3 comments)

very nice except for the changing filename

https://gerrit.osmocom.org/#/c/4703/1//COMMIT_MSG
Commit Message:

Line 10: as getting different location areas for BTS.
well, getting the codes yes, not the areas themselves ;)


https://gerrit.osmocom.org/#/c/4703/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 195:             token_path = self.state_dir.child(token + '_last_used.state')
-1: let's rather make it 'last_used_%s.state' % token, then we will continue using the same state file instead of creating a new one on our tester instances.


Line 206:             validate_func(next_value)
0: do you not trust the inc_func?


-- 
To view, visit https://gerrit.osmocom.org/4703
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib04a34892aacd7e71f8f5961e7339add583f73f2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list