[PATCH] libosmo-sccp[master]: vty: skip installing cmds now always installed by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Nov 1 00:05:19 UTC 2017


Review at  https://gerrit.osmocom.org/4607

vty: skip installing cmds now always installed by default

vty_install_default() and install_default() will soon be deprecated.

Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: I185aa3a11cb63c893ed80f326f852bde95217321
---
M examples/sccp_test_vty.c
M src/osmo_ss7_vty.c
2 files changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/07/4607/1

diff --git a/examples/sccp_test_vty.c b/examples/sccp_test_vty.c
index d809fbc..c477c8b 100644
--- a/examples/sccp_test_vty.c
+++ b/examples/sccp_test_vty.c
@@ -139,7 +139,6 @@
 	g_calling_addr.ssn = ssn;
 
 	install_node(&scu_node, NULL);
-	vty_install_default(SCU_NODE);
 	install_element(SCU_NODE, &scu_called_ssn_cmd);
 	install_element(SCU_NODE, &scu_conn_req_cmd);
 	install_element(SCU_NODE, &scu_conn_resp_cmd);
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 8d13865..2c3d78e 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1683,7 +1683,6 @@
 static void vty_init_addr(void)
 {
 	install_node(&sccpaddr_node, NULL);
-	vty_install_default(L_CS7_SCCPADDR_NODE);
 	install_element(L_CS7_NODE, &cs7_show_sccpaddr_cmd);
 	install_element(L_CS7_NODE, &cs7_sccpaddr_cmd);
 	install_element(L_CS7_NODE, &cs7_sccpaddr_del_cmd);
@@ -1706,7 +1705,6 @@
 #endif
 	install_element(L_CS7_SCCPADDR_NODE, &cs7_sccpaddr_gt_cmd);
 	install_node(&sccpaddr_gt_node, NULL);
-	vty_install_default(L_CS7_SCCPADDR_GT_NODE);
 	install_element(L_CS7_SCCPADDR_GT_NODE, &cs7_sccpaddr_gt_gti_cmd);
 	install_element(L_CS7_SCCPADDR_GT_NODE, &cs7_sccpaddr_gt_tt_cmd);
 	install_element(L_CS7_SCCPADDR_GT_NODE, &cs7_sccpaddr_gt_npi_cmd);
@@ -1724,7 +1722,6 @@
 	install_element(CONFIG_NODE, &cs7_instance_cmd);
 
 	install_node(&cs7_node, config_write_cs7);
-	vty_install_default(L_CS7_NODE);
 	install_element(L_CS7_NODE, &cfg_description_cmd);
 	install_element(L_CS7_NODE, &cs7_net_ind_cmd);
 	install_element(L_CS7_NODE, &cs7_point_code_cmd);
@@ -1734,7 +1731,6 @@
 	install_element(L_CS7_NODE, &cs7_permit_dyn_rkm_cmd);
 
 	install_node(&asp_node, NULL);
-	vty_install_default(L_CS7_ASP_NODE);
 	install_element_ve(&show_cs7_asp_cmd);
 	install_element(L_CS7_NODE, &cs7_asp_cmd);
 	install_element(L_CS7_NODE, &no_cs7_asp_cmd);
@@ -1746,7 +1742,6 @@
 	install_element(L_CS7_ASP_NODE, &asp_shutdown_cmd);
 
 	install_node(&as_node, NULL);
-	vty_install_default(L_CS7_AS_NODE);
 	install_element_ve(&show_cs7_as_cmd);
 	install_element(L_CS7_NODE, &cs7_as_cmd);
 	install_element(L_CS7_NODE, &no_cs7_as_cmd);
@@ -1777,7 +1772,6 @@
 	vty_init_shared(ctx);
 
 	install_node(&rtable_node, NULL);
-	vty_install_default(L_CS7_RTABLE_NODE);
 	install_element_ve(&show_cs7_route_cmd);
 	install_element(L_CS7_NODE, &cs7_route_table_cmd);
 	install_element(L_CS7_RTABLE_NODE, &cfg_description_cmd);
@@ -1785,7 +1779,6 @@
 	install_element(L_CS7_RTABLE_NODE, &cs7_rt_rem_cmd);
 
 	install_node(&xua_node, NULL);
-	vty_install_default(L_CS7_XUA_NODE);
 	install_element(L_CS7_NODE, &cs7_xua_cmd);
 	install_element(L_CS7_NODE, &no_cs7_xua_cmd);
 	install_element(L_CS7_XUA_NODE, &xua_local_ip_cmd);

-- 
To view, visit https://gerrit.osmocom.org/4607
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I185aa3a11cb63c893ed80f326f852bde95217321
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list