osmo-hlr[master]: VTY: Add hlr node and bind ip field

[Neels Hofmeyr]

Patch Set 1: Code-Review-1

(6 comments)

https://gerrit.osmocom.org/#/c/2809/1/doc/examples/osmo-hlr.cfg
File doc/examples/osmo-hlr.cfg:

Line 18:  bind ip 127.0.0.1
name GSUP explicitly; either as another VTY parent node or as 'gsup bind ip...' -- can't decide yet which I favor. If we are going to have more GSUP specific entries, a 'gsup' parent node would make sense... Yes, I think I would favor another node level:

  hlr
   gsup
    bind ip A.B.C.D
    bind port 1-65535


https://gerrit.osmocom.org/#/c/2809/1/src/hlr.c
File src/hlr.c:

Line 438: 	hlr_vty_init(g_hlr, &hlr_log_info, hlr_ctx);
g_hlr is also a talloc'd item, and it would indeed make more sense to use that as talloc ctx for the VTY config, which stores the config values in g_hlr. Those could be passed in unison, i.e. without a separate hlr_ctx arg. (or pass g_hlr for both of the args).


https://gerrit.osmocom.org/#/c/2809/1/src/hlr.h
File src/hlr.h:

Line 39: 	char *bind_addr;
this should also say 'gsup_bind_addr'. (While at it, we could also add the gsup_bind_port, but it can also wait till later)


https://gerrit.osmocom.org/#/c/2809/1/src/hlr_vty.c
File src/hlr_vty.c:

Line 61:       "IPv4 Address to bind to\n")
"GSUP"


Line 65:         g_hlr->bind_addr = talloc_strdup(tall_hlr_ctx, argv[0]);
s/tall_hlr_ctx/g_hlr


https://gerrit.osmocom.org/#/c/2809/1/src/hlr_vty.h
File src/hlr_vty.h:

Line 35: void hlr_vty_init(struct hlr *hlr, const struct log_info *cat, void *tall_ctx);
in most osmo code we pass the tall_ctx as first argument, if we have one.


-- 
To view, visit https://gerrit.osmocom.org/2809
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f7a300480f308b21116dd14d1698be38725afd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes