This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged. Change subject: fix: Sms.__eq__ bug due to typo ...................................................................... fix: Sms.__eq__ bug due to typo Add test of this to sms_test.py Change-Id: Ib0b420a81c1b211a9f03a2521d244b3a427d5e5b --- M selftest/sms_test.py M src/osmo_gsm_tester/sms.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/selftest/sms_test.py b/selftest/sms_test.py index ce81c3e..01cecc2 100755 --- a/selftest/sms_test.py +++ b/selftest/sms_test.py @@ -17,4 +17,6 @@ print(str(msg2)) assert msg == msg2 +assert msg == str(msg.msg) + # vim: expandtab tabstop=4 shiftwidth=4 diff --git a/src/osmo_gsm_tester/sms.py b/src/osmo_gsm_tester/sms.py index 64eca5a..7fcb2d9 100644 --- a/src/osmo_gsm_tester/sms.py +++ b/src/osmo_gsm_tester/sms.py @@ -40,7 +40,7 @@ def __eq__(self, other): if isinstance(other, Sms): return self.msg == other.msg - return inself.msg == other + return self.msg == other def matches(self, msg): return self.msg == msg -- To view, visit https://gerrit.osmocom.org/2814 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b420a81c1b211a9f03a2521d244b3a427d5e5b Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>