[PATCH] osmo-gsm-tester[master]: ofono_client: Fix race condition when checking for required ...

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/2798

ofono_client: Fix race condition when checking for required features

I got a backtrace in which the modem was lacking feature 'net'. That
happens for 2 reasons:
1- net feature is not shown unless the modem is Online (at least for
sierra modems)
2- Even after it has been set online, a lapse of time can pass before
the feature gets shown.

Change-Id: Iedd62235d1a3a8b917ad4ac0b61b9c5dbf0fe43c
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/98/2798/1

diff --git a/src/osmo_gsm_tester/ofono_client.py b/src/osmo_gsm_tester/ofono_client.py
index ce937d0..38e5772 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -243,14 +243,6 @@
     def is_online(self):
         return self.property_is('Online', True)
 
-    def require_features(self, *required):
-        '''Make sure the given feature strings are present in
-        properties()['Features'], raise an exception otherwise.'''
-        features = set(self.properties().get('Features'))
-        r = set(required)
-        if not (r < features):
-            self.raise_exn('This modem lacks features:', r - features)
-
 
 
 class Modem(log.Origin):
@@ -265,7 +257,6 @@
         self.set_log_category(log.C_TST)
         self.sms_received_list = []
         self.dbus = ModemDbusInteraction(self.path)
-        self.dbus.require_features('sms', 'net')
         self.dbus.required_signals = {
                 I_SMS: ( ('IncomingMessage', self._on_incoming_message), ),
             }

-- 
To view, visit https://gerrit.osmocom.org/2798
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedd62235d1a3a8b917ad4ac0b61b9c5dbf0fe43c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>