openggsn[master]: libgtp: improve error logging and propagation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri May 26 15:35:58 UTC 2017


Patch Set 2:

Looking at other functions in gtp.c I fail to determine common style. Some functions return 0 on errors, other return -1, yet other return 0 on success but EOF on errors. I can drop this part of the change - it turned out that the error I've been hunting down lies elsewhere so it doesn't really matter. What do you think?

-- 
To view, visit https://gerrit.osmocom.org/2655
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07f1e4246eb178838b7df21946a08a1f60f2084
Gerrit-PatchSet: 2
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list