This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/2734 cosmetic: comment and SMS token tweak Change-Id: I66b8f30303e21ad781d16f3aa9fe30067d6a0e20 --- M src/osmo_gsm_tester/ofono_client.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/34/2734/1 diff --git a/src/osmo_gsm_tester/ofono_client.py b/src/osmo_gsm_tester/ofono_client.py index ee93a6e..4239b68 100644 --- a/src/osmo_gsm_tester/ofono_client.py +++ b/src/osmo_gsm_tester/ofono_client.py @@ -295,8 +295,12 @@ event_loop.wait(self, self.dbus.has_interface, I_NETREG, I_SMS, timeout=10) def sms_send(self, to_msisdn, *tokens): + # shim: if the caller passed a modem object instead of an MSISDN string if hasattr(to_msisdn, 'msisdn'): to_msisdn = to_msisdn.msisdn + # and maybe we can tickle some more info out of it? + if hasattr(to_msisdn, 'name'): + tokens.append('to ' + to_msisdn.name()) sms = Sms(self.msisdn, to_msisdn, 'from ' + self.name(), *tokens) self.log('sending sms to MSISDN', to_msisdn, sms=sms) if not self.dbus.has_interface(I_SMS): -- To view, visit https://gerrit.osmocom.org/2734 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I66b8f30303e21ad781d16f3aa9fe30067d6a0e20 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>