This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/2389/6/src/common/measurement.c File src/common/measurement.c: Line 140: DEBUGP(DMEAS, I think we can simply pass the lchan into "is_meas_complete" and replace the pchan, ts and subch arguments wih it. At that point, we can use the gsm_lchan_name() function to get a descriptive log prefix. Line 216: if (!is_meas_complete(ts_pchan(lchan->ts), lchan->ts->nr, this seems like the only caller of is_meas_complete() and it derives all three firsrt arguments from lchan. So as suggested above, pass the lchan into the function and avoid re-implemnenting gsm_lchan_name() -- To view, visit https://gerrit.osmocom.org/2389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f Gerrit-PatchSet: 6 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes