This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
so far just a hint on the KeyError problem.
In general I'm not following why this patch is so complex; need to take a look later and discuss with you...
https://gerrit.osmocom.org/#/c/2696/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 112: event_loop.wait(log_obj, modem_has_val_in_property, dbus_obj, I_MODEM, 'Interfaces', I_SIM)
after news from OS#2233, it seems you need to add here:
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -110,6 +110,8 @@ def build_imsi_modem_map(log_obj, reserved):
log_obj.dbg('modem %s has no sim feature, skipping' % modem_path)
if has_sim_feature:
event_loop.wait(log_obj, modem_has_val_in_property, dbus_obj, I_MODEM, 'Interfaces', I_SIM)
+ # refresh the DBus object to re-evaluate what interfaces are available
+ dbus_obj = systembus_get(modem_path)
sim_prop = dbus_obj[I_SIM].GetProperties()
imsi = sim_prop.get('SubscriberIdentity')
if imsi:
--
To view, visit https://gerrit.osmocom.org/2696
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I602604d25f51b24d87877bc8ac798525b7be61dd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes