This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged.
Change subject: trial.py: Remove accidental double creation of file
......................................................................
trial.py: Remove accidental double creation of file
This file is already created in run_suites().
Creating it in here too makes a new file name()_2.xml created and
populated instead of the original name().xml one.
Change-Id: Ibec14a1ef5fd029aa37ce666d00236bb872d636e
---
M selftest/trial_test.ok
M src/osmo_gsm_tester/trial.py
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/selftest/trial_test.ok b/selftest/trial_test.ok
index 7434a10..6ad39a9 100644
--- a/selftest/trial_test.ok
+++ b/selftest/trial_test.ok
@@ -4,7 +4,7 @@
[TMP]/third
- fetch trial dirs in order
first
-['last_run', 'run.[TIMESTAMP]', 'taken']
+['taken']
second
third
- no more trial dirs left
diff --git a/src/osmo_gsm_tester/trial.py b/src/osmo_gsm_tester/trial.py
index 67746f7..3eb0c67 100644
--- a/src/osmo_gsm_tester/trial.py
+++ b/src/osmo_gsm_tester/trial.py
@@ -63,7 +63,6 @@
self.inst_dir = util.Dir(self.dir.child('inst'))
self.bin_tars = []
self.suites = []
- self.junit_path = self.get_run_dir().new_file(self.name()+'.xml')
self.status = Trial.UNKNOWN
def __repr__(self):
--
To view, visit https://gerrit.osmocom.org/2724
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec14a1ef5fd029aa37ce666d00236bb872d636e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>