This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review-1
(8 comments)
https://gerrit.osmocom.org/#/c/2719/2/example/defaults.conf
File example/defaults.conf:
Line 14: short_name: osmo-gsm-tester-msc
Shall both msc and bsc have a short_name and long_name?
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/osmo_bsc.py
File src/osmo_gsm_tester/osmo_bsc.py:
Line 25: class OsmoBsc(log.Origin):
Now that we have the BTS talking with the same API to both the OsmoNitb and OsmoBC, I'm wondering if it would be good to have some interface or class which defines the methods, then subclass it in OsmoBsc and OsmoNITB?
Also some of the common function can be handled there (such as bts_add() or is_running()).
Line 35: self.eth_iface = eth_iface
So the conclusion finally was to leave it as eth_iface? I thought we concluded is not the best name.
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/osmo_hlr.py
File src/osmo_gsm_tester/osmo_hlr.py:
Line 84: self.dbg(conf=values)
You may want to add: 'HLR CONFIG:\n' +
As done in other files
Line 107: self.run_local(name, ('/bin/sh', '-c', 'sqlite3 %r < %r' % (self.db_file, sql_file)))
You need to add sqlite3 to the dependecies in the README file.
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/osmo_msc.py
File src/osmo_gsm_tester/osmo_msc.py:
Line 115: var = 'subscriber-list-active-v1'
This line can be removed
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl:
Line 8
There's no specific hlr section?
https://gerrit.osmocom.org/#/c/2719/2/src/osmo_gsm_tester/templates/osmo-mgcpgw.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-mgcpgw.cfg.tmpl:
Line 9: local ip ${mgcpgw.eth_iface.addr}
again, eth_iface?
--
To view, visit https://gerrit.osmocom.org/2719
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5842e8f1cba8e8e6bedfc08540efcafe207159cb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes