osmo-gsm-tester[master]: rename resource nitb_iface to eth_iface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon May 22 21:27:52 UTC 2017


Patch Set 2:

(1 comment)

> IMHO 'public' can be misunderstood as 'not loopback'.

Of course this is exactly what you meant, sorry :P

 > We will name it either bind_addr or local_addr (matching the names
 > we use in the VTY config).

This is about the member names for classes. The global resource type is now going to be called 'ip_address' with possibly a type modifier being added later to distinguish public from loopback.

https://gerrit.osmocom.org/#/c/2681/2/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 44: R_NITB_IFACE = 'eth_iface'
> missing change here. (NITB). You may want to run grep with CAPS enabled.
ah, thanks!


-- 
To view, visit https://gerrit.osmocom.org/2681
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I829903d7b2111ab5ee106bce52d6121204a5a401
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list