This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/2692/1/example/defaults.conf File example/defaults.conf: Line 13: cell_identity: 0 > i.e. for now all BTS have a cell_identity == 0? As you say, the issue stated here is not specific to this patch and can be solved later in the same way that other values are to be specified when we have more than 1 BTS, so please let's not make this patch attempt to fix all open issues at once. I'd go first for A) then for C), but both in later patches. https://gerrit.osmocom.org/#/c/2692/1/src/osmo_gsm_tester/bts_sysmo.py File src/osmo_gsm_tester/bts_sysmo.py: Line 145: return int(self.conf_for_nitb()['cell_identity']) > Let's not store the for_nitb config in the BTS, this would duplicate values OK For now I will do: In configure() I get 'cell_identity' from 'nitb_bts' and I add it using config.overlay(values) https://gerrit.osmocom.org/#/c/2692/1/src/osmo_gsm_tester/osmo_nitb.py File src/osmo_gsm_tester/osmo_nitb.py: Line 155 > correct but unrelated. rather submit in a separate patch. OK will split this Line 196: ctrl.do_get(OsmoNitbCtrl.BTS_CELL_IDENTITY_VAR % i) > hmm, what if the number of connected BTS changes between count_bts_connecte afair I have been told the CTRL APIs are changing (improving) with the new split of NITB->MSC+BSC. Let's keep like this for now and improve the code with the new APIs when the NITB->BSC+MSC is done, as it may need work on BSC itself. Line 219: > (drop some blank lines) Agree -- To view, visit https://gerrit.osmocom.org/2692 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bbf9ac2b05d95a113ed4ad5e93093431496d44e Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes