osmo-bts[master]: osmo-bts-trx: use libosmocoding

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu May 18 21:24:33 UTC 2017


Patch Set 2: Code-Review-1

(3 comments)

In general, looks fine to me. As soon as my warnings
would be addressed, I'll give CR+1.

P.S. Thanks! This is the final step in GSM 05.03 migration.

https://gerrit.osmocom.org/#/c/2674/2/src/osmo-bts-trx/scheduler_trx.c
File src/osmo-bts-trx/scheduler_trx.c:

Line 617: 				       chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr);
I think it would be better to do white space
modifications in separate commit.


Line 697: 			"trx=%u ts=%u at fn=%u to transmit.\n", 
... and strip such things too ;)


https://gerrit.osmocom.org/#/c/2674/2/tests/bursts/Makefile.am
File tests/bursts/Makefile.am:

Line 7: bursts_test_SOURCES = bursts_test.c
We don't need this test, because one was migrated
to libosmocoding too.


-- 
To view, visit https://gerrit.osmocom.org/2674
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b41bb1a8de655639107ec1f3b75afc240fd316f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list