osmo-gsm-tester[report]: Handle termination signals to exit gracefully and prevent re...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 18 13:26:42 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2670/1/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 313:         finally:
> I meant: do you really need to register signal handlers? isn't this 'try:..
The default signal handler (KeyboardInterrupt) doesn't work in all cases. See https://stackoverflow.com/questions/40775054/capturing-sigint-using-keyboardinterrupt-exception-works-in-terminal-not-in-scr/40785230#40785230

On top of that, the KeyboardInterrupt works for SIGINT but it's not used for SIGTERM for instance, which means if you send kill to it you leak resources.


-- 
To view, visit https://gerrit.osmocom.org/2670
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: report
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list