osmocom-bb[master]: host/mobile: use osmocom_ms as talloc context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 17 18:11:10 UTC 2017


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/2668/1/src/host/layer23/include/osmocom/bb/mobile/mncc_sock.h
File src/host/layer23/include/osmocom/bb/mobile/mncc_sock.h:

Line 13
why not simply use 'inst' as the talloc context? We already have that as an argument, and it seems to be the 'ms' (which is a talloc context)?  Am I missing something?


https://gerrit.osmocom.org/#/c/2668/1/src/host/layer23/include/osmocom/bb/mobile/subscriber.h
File src/host/layer23/include/osmocom/bb/mobile/subscriber.h:

Line 102: int gsm_subscr_add_forbidden_plmn(struct gsm_subscriber *subscr, uint16_t mcc,
Is there not a 1:1 relationship between subscr and ms, so we can do this without adding 'ms' as argument?


-- 
To view, visit https://gerrit.osmocom.org/2668
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d5fcbdd77fe41d78cfe54731dd2ebfc4171f62c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list