osmocom-bb[master]: host/mobile: use talloc for ms->name allocation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 17 18:07:33 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2667/1/src/host/layer23/src/mobile/vty_interface.c
File src/host/layer23/src/mobile/vty_interface.c:

Line 1274: 		vty_out(vty, "Couldn't rename MS: no memory%s", VTY_NEWLINE);
I think we have the policy to not cope with memory allocation failures, as this kind of code (log statements for each failed allocation) would just add lots of clutter.

So if you want to do anything, you could simply OSMO_ASSERT()on the allocation failure.

We could even do that more generically by having a wrapper around all allocations that includes that assert.


-- 
To view, visit https://gerrit.osmocom.org/2667
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6706117fdd7f1b3481b0e3817bbb3b31f12f60
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list