[MERGED] libosmocore[master]: sercomm: Move HDLC related defines into C file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 17 17:36:48 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: sercomm: Move HDLC related defines into C file
......................................................................


sercomm: Move HDLC related defines into C file

Those values are not relevant to the sercomm user, only to the
implementation and thus can remain inside sercomm.c

Change-Id: I5700a45985b7c119c6338932171aae62ee4e2d22
---
M include/osmocom/core/sercomm.h
M src/sercomm.c
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/sercomm.h b/include/osmocom/core/sercomm.h
index 3d986c6..0583390 100644
--- a/include/osmocom/core/sercomm.h
+++ b/include/osmocom/core/sercomm.h
@@ -3,13 +3,6 @@
 
 #include <osmocom/core/msgb.h>
 
-#define HDLC_FLAG	0x7E
-#define HDLC_ESCAPE	0x7D
-
-#define HDLC_C_UI	0x03
-#define HDLC_C_P_BIT	(1 << 4)
-#define HDLC_C_F_BIT	(1 << 4)
-
 /* a low sercomm_dlci means high priority.  A high DLCI means low priority */
 enum sercomm_dlci {
 	SC_DLCI_HIGHEST = 0,
diff --git a/src/sercomm.c b/src/sercomm.c
index dbe3d05..75e7968 100644
--- a/src/sercomm.c
+++ b/src/sercomm.c
@@ -58,6 +58,13 @@
 
 #endif
 
+#define HDLC_FLAG	0x7E
+#define HDLC_ESCAPE	0x7D
+
+#define HDLC_C_UI	0x03
+#define HDLC_C_P_BIT	(1 << 4)
+#define HDLC_C_F_BIT	(1 << 4)
+
 enum rx_state {
 	RX_ST_WAIT_START,
 	RX_ST_ADDR,

-- 
To view, visit https://gerrit.osmocom.org/2639
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5700a45985b7c119c6338932171aae62ee4e2d22
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list