[PATCH] osmo-bts[master]: measurement: Improve log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed May 17 16:58:24 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2389

to look at the new patch set (#4).

measurement: Improve log output

The debug log does not print much information about the measured
rxlev and rxqual values. This commit adds debug output to make
measurement debugging simpler

Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f
---
M src/common/measurement.c
M src/common/rsl.c
2 files changed, 27 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/2389/4

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 22ab27c..c707bd4 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -136,6 +136,11 @@
 		rc = 0;
 		break;
 	}
+
+	DEBUGP(DMEAS,
+	       "(ts=%u,ss=%u,fn=%u,fn_mod=%i), meas period end status:%d for chan:%s\n",
+	       ts, subch, fn, fn_mod, rc, gsm_pchan_name(pchan));
+
 	return rc;
 }
 
@@ -256,6 +261,14 @@
 	mru->full.rx_qual = ber10k_to_rxqual(ber_full_sum);
 	mru->sub.rx_qual = ber10k_to_rxqual(ber_sub_sum);
 
+	DEBUGP(DMEAS, "%s UL MEAS RXLEV_FULL(%u), RXLEV_SUB(%u),"
+	       "RXQUAL_FULL(%u), RXQUAL_SUB(%u), num_meas_sub(%u), num_ul_meas(%u) \n",
+	       gsm_lchan_name(lchan),
+	       mru->full.rx_lev,
+	       mru->sub.rx_lev,
+	       mru->full.rx_qual,
+	       mru->sub.rx_qual, num_meas_sub, lchan->meas.num_ul_meas);
+
 	lchan->meas.flags |= LC_UL_M_F_RES_VALID;
 	lchan->meas.num_ul_meas = 0;
 
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 51d23d6..a0060df 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2245,8 +2245,9 @@
 	uint8_t chan_nr = gsm_lchan2chan_nr(lchan);
 	int res_valid = lchan->meas.flags & LC_UL_M_F_RES_VALID;
 
-	LOGP(DRSL, LOGL_DEBUG, "%s Tx MEAS RES valid(%d)\n",
-		gsm_lchan_name(lchan), res_valid);
+	LOGP(DRSL, LOGL_DEBUG,
+	     "%s chan_num:%d Tx MEAS RES valid(%d), flags(%d)\n",
+	     gsm_lchan_name(lchan), chan_nr, res_valid, lchan->meas.flags);
 
 	if (!res_valid)
 		return -EINPROGRESS;
@@ -2255,6 +2256,17 @@
 	if (!msg)
 		return -ENOMEM;
 
+	LOGP(DRSL, LOGL_DEBUG,
+	     "%s Send Meas RES: NUM:%d, RXLEV_FULL:%d, RXLEV_SUB:%d, RXQUAL_FULL:%d, RXQUAL_SUB:%d, MS_PWR:%d, UL_TA:%d, L3_LEN:%d, TimingOff:%u\n",
+	     gsm_lchan_name(lchan),
+	     lchan->meas.res_nr,
+	     lchan->meas.ul_res.full.rx_lev,
+	     lchan->meas.ul_res.sub.rx_lev,
+	     lchan->meas.ul_res.full.rx_qual,
+	     lchan->meas.ul_res.sub.rx_qual,
+	     lchan->meas.l1_info[0],
+	     lchan->meas.l1_info[1], l3_len, lchan->meas.ms_timing_offset);
+
 	msgb_tv_put(msg, RSL_IE_MEAS_RES_NR, lchan->meas.res_nr++);
 	size_t ie_len = gsm0858_rsl_ul_meas_enc(&lchan->meas.ul_res,
 						lchan->tch.dtx.dl_active,

-- 
To view, visit https://gerrit.osmocom.org/2389
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list