osmo-gsm-tester[report]: Free resources and kill subprocesses when signal to stop is ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed May 17 14:44:56 UTC 2017


Patch Set 1:

(4 comments)

I don't fully understand yet :)

https://gerrit.osmocom.org/#/c/2670/1//COMMIT_MSG
Commit Message:

Line 7: Free resources and kill subprocesses when signal to stop is received
"handle Ctrl+C and other signals gracefully" ?

Please add a description of the failure case you are seeing. Because indeed for me, I would usually hit Ctrl+C and get full teardown and result reporting fine. At what places does Ctrl+C not have the desired effect?


https://gerrit.osmocom.org/#/c/2670/1/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 299:         # if sys.exit() called from SIGTINT handler, SystemExit base exception
SIGINT ... or rather "signal handler" since you're handling various signals


Line 301:         # section:
(let's have this comment in the finally section)


Line 313:         finally:
possibly this "finally:" is the only required change?


-- 
To view, visit https://gerrit.osmocom.org/2670
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I039e4d1908a04bf606b101ddc6a186ba67e6178e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: report
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list