[PATCH] osmocom-bb[master]: mobile/gsm322.c: avoid using memset with zero length

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 16 22:13:12 UTC 2017


Review at  https://gerrit.osmocom.org/2664

mobile/gsm322.c: avoid using memset with zero length

Change-Id: Ifc8a06dd100ce494e3bcfbc7636738435fa5e34d
---
M src/host/layer23/src/mobile/gsm322.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/2664/1

diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c
index ebe22ff..325852d 100644
--- a/src/host/layer23/src/mobile/gsm322.c
+++ b/src/host/layer23/src/mobile/gsm322.c
@@ -322,7 +322,9 @@
 	else
 		value -= min;
 
-	memset(bar, '=', value);
+	if (value)
+		memset(bar, '=', value);
+
 	bar[value] = '\0';
 
 	return bar;

-- 
To view, visit https://gerrit.osmocom.org/2664
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc8a06dd100ce494e3bcfbc7636738435fa5e34d
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list