[PATCH] osmo-gsm-tester[master]: fix: exception outside of trial run should be logged and cau...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun May 14 18:21:52 UTC 2017


Review at  https://gerrit.osmocom.org/2604

fix: exception outside of trial run should be logged and cause nonzero rc

>From an earlier stage of the code, there was still an exception catcher that
makes no sense. Remove it.

Change-Id: I8085318c91b06a3e8f7d3f8cfdd15a99650666e2
---
M src/osmo-gsm-tester.py
1 file changed, 10 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/04/2604/1

diff --git a/src/osmo-gsm-tester.py b/src/osmo-gsm-tester.py
index e38fae6..7f53750 100755
--- a/src/osmo-gsm-tester.py
+++ b/src/osmo-gsm-tester.py
@@ -70,7 +70,7 @@
 from osmo_gsm_tester import __version__
 from osmo_gsm_tester import trial, suite, log, config
 
-if __name__ == '__main__':
+def main():
     import argparse
 
     parser = argparse.ArgumentParser(epilog=__doc__, formatter_class=argparse.RawTextHelpFormatter)
@@ -166,11 +166,8 @@
     trials = []
     for trial_package in args.trial_package:
         t = trial.Trial(trial_package)
-        try:
-            t.verify()
-            trials.append(t)
-        except:
-            t.log_exn()
+        t.verify()
+        trials.append(t)
 
     trials_passed = []
     trials_failed = []
@@ -212,4 +209,11 @@
                 print('    FAIL:', suite)
         exit(1)
 
+if __name__ == '__main__':
+    try:
+        main()
+    except:
+        log.log_exn()
+        raise
+
 # vim: expandtab tabstop=4 shiftwidth=4

-- 
To view, visit https://gerrit.osmocom.org/2604
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8085318c91b06a3e8f7d3f8cfdd15a99650666e2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list