osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue May 9 10:26:12 UTC 2017


Patch Set 2:

(9 comments)

https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/netlogger.py
File src/osmo_gsm_tester/netlogger.py:

Line 27: class NetLogger(log.Origin):
> don't really like the name, sounds like the gsm tester would write its own 
Fine with change it to PcapRecorder


Line 32:         self.host = host
> are user and host actually used?
I added them because I was expecting to be able to run the recording on a remote system at some point (ssh+tcpdump), but after the discussion on GSMTAP forwaring to the NITB, I think it's no longer needed and we can drop it.


Line 40:         self.log('Starting logger', self.run_dir, self.gen_filter())
> same. 'Recording pcap'?
Agree


Line 42:         # TODO: if host not None, launch it remotely
> I hope we won't need that :)
Agree


Line 52:     def set_addr(self, addr):
> pass this to constructor instead?
Agree


Line 55:     def set_iface(self, iface):
> pass this to constructor instead?
Agree


https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/osmo_nitb.py
File src/osmo_gsm_tester/osmo_nitb.py:

Line 54:         nl = netlogger.NetLogger(self.suite_run, self.run_dir.new_dir('pcap'))
> the run dir is intended to record stdout and stderr of a running process, a
I don't agree here. The stderr/stdout for tcpdump is important because for instance it tells you if some packets were lost during the recording, which is something you should check before trying to understand the trace and become fool when missing some of them. I've actually seen this on other test environments when they are fully loaded with running tests, believe me.


Line 59:         nl.start()
> maybe do all this in just the constructor call? (i.e. do the iface resoluti
I think we can postpone this for now as it doesn't seem to be an issue in the current status.


https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/util.py
File src/osmo_gsm_tester/util.py:

Line 49:         print('Failed to retreive iface:', e)
> let's drop the print and leave it up to the caller to log an error.
Agree


-- 
To view, visit https://gerrit.osmocom.org/2541
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list