This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pablo Neira Ayuso gerrit-no-reply at lists.osmocom.orgPatch Set 3: (1 comment) Sorry. I misunderstood. I'm recovering the previous version, I missed that you added Code Review+2 there. So you seem to be fine with the previous version. Thanks! https://gerrit.osmocom.org/#/c/2542/2/src/timer.c File src/timer.c: Line 73: osmo_timer_del(timer); > one could argue that could be an inline (it's basically just two unconditio Yes, that would be definitely faster. I'm going to follow that path, this timer interface has proven to be quite stable, so placing this in the library header file shouldn't be much of a problem. -- To view, visit https://gerrit.osmocom.org/2542 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa49972ecaab3748b25168b26d92034e9145666 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pablo at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org> Gerrit-HasComments: Yes