libosmocore[master]: timer: add osmo_timer_setup()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon May 8 17:45:45 UTC 2017


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/2542/2/src/timer.c
File src/timer.c:

Line 73: void osmo_timer_setup(struct osmo_timer_list *timer, void (*cb)(void *data),
one could argue that could be an inline (it's basically just two unconditional stores, so no need for function prologue, call, return, ...) but "premature optimization is the root of all evil"...


-- 
To view, visit https://gerrit.osmocom.org/2542
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa49972ecaab3748b25168b26d92034e9145666
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list