[MERGED] osmo-gsm-tester[master]: sms: don't log info

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon May 8 10:12:01 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: sms: don't log info
......................................................................


sms: don't log info

Change-Id: Ie9c4757de1eedcbcc85b7b99b94d164cc6ae3c59
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/ofono_client.py b/src/osmo_gsm_tester/ofono_client.py
index 5b7d0d2..f4ec08a 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -197,13 +197,13 @@
         return sms
 
     def _on_incoming_message(self, message, info):
-        self.log('Incoming SMS:', repr(message), info=info)
+        self.log('Incoming SMS:', repr(message))
         self.sms_received_list.append((message, info))
 
     def sms_was_received(self, sms):
         for msg, info in self.sms_received_list:
             if sms.matches(msg):
-                self.log('SMS received as expected:', msg=msg, info=info)
+                self.log('SMS received as expected:', repr(msg))
                 return True
         return False
 

-- 
To view, visit https://gerrit.osmocom.org/2503
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9c4757de1eedcbcc85b7b99b94d164cc6ae3c59
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list