[PATCH] osmo-gsm-tester[master]: ofono_client: drop explicit exception catching

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri May 5 16:39:16 UTC 2017


Review at  https://gerrit.osmocom.org/2485

ofono_client: drop explicit exception catching

For some reason the code there catches exceptions happening while interfaces
are being established. That's not a good idea, drop it.

Related: OS#2220
Change-Id: Ida7731ed6ff3cad44ff437137abe2d6a424fcaa4
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/85/2485/1

diff --git a/src/osmo_gsm_tester/ofono_client.py b/src/osmo_gsm_tester/ofono_client.py
index 1f0380a..9a018e1 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -119,16 +119,10 @@
         self._interfaces = now
         for iface in removals:
             with log.Origin('modem.disable(%s)' % iface):
-                try:
-                    self._on_interface_disabled(iface)
-                except:
-                    self.log_exn()
+                self._on_interface_disabled(iface)
         for iface in additions:
             with log.Origin('modem.enable(%s)' % iface):
-                try:
-                    self._on_interface_enabled(iface)
-                except:
-                    self.log_exn()
+                self._on_interface_enabled(iface)
 
     def _on_interface_enabled(self, interface_name):
         self.dbg('Interface enabled:', interface_name)

-- 
To view, visit https://gerrit.osmocom.org/2485
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida7731ed6ff3cad44ff437137abe2d6a424fcaa4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list