[PATCH] openbsc[master]: Gb: use textual representation instead for log

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri May 5 11:25:55 UTC 2017


Review at  https://gerrit.osmocom.org/2482

Gb: use textual representation instead for log

Use textual representation for message type and protocol descriminator
in case of Gb parsing errors.

Change-Id: Ida925258be119619d8705361730c554a130b75bc
Related: SYS#3610
---
M openbsc/src/gprs/gprs_gb_parse.c
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/82/2482/1

diff --git a/openbsc/src/gprs/gprs_gb_parse.c b/openbsc/src/gprs/gprs_gb_parse.c
index 9befa39..d5a122b 100644
--- a/openbsc/src/gprs/gprs_gb_parse.c
+++ b/openbsc/src/gprs/gprs_gb_parse.c
@@ -380,9 +380,8 @@
 
 	default:
 		LOGP(DLLC, LOGL_NOTICE,
-		     "Unknown GSM 04.08 message type 0x%02hhx for protocol"
-		     " discriminator 0x%02hhx.\n",
-		     msg_type, pdisc);
+		     "Unhandled GSM 04.08 message type %s for protocol discriminator %s.\n",
+		     get_value_string(gprs_msgt_gmm_names, msg_type), get_value_string(gsm48_pdisc_names, pdisc));
 		break;
 	};
 

-- 
To view, visit https://gerrit.osmocom.org/2482
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida925258be119619d8705361730c554a130b75bc
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list