[PATCH] osmo-gsm-tester[master]: ofono_client: Sort events more logically

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 4 11:07:40 UTC 2017


Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2471

to look at the new patch set (#2).

ofono_client: Sort events more logically

Change-Id: I515203a14cf629e789a7f7659d43126898ab4534
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/71/2471/2

diff --git a/src/osmo_gsm_tester/ofono_client.py b/src/osmo_gsm_tester/ofono_client.py
index 65a8791..df9e1c7 100644
--- a/src/osmo_gsm_tester/ofono_client.py
+++ b/src/osmo_gsm_tester/ofono_client.py
@@ -58,6 +58,8 @@
         self._dbus_obj = None
         self._interfaces = set()
         self.sms_received_list = []
+        # init interfaces and connect to signals:
+        self.dbus_obj()
         test.poll()
 
     def set_msisdn(self, msisdn):
@@ -152,9 +154,9 @@
     def connect(self, nitb):
         'set the modem up to connect to MCC+MNC from NITB config'
         self.log('connect to', nitb)
+        self.set_online(False)
         self.set_powered(False)
         self.set_powered()
-        self.set_online(False)
         self.set_online()
         if not self.has_interface(I_NETREG):
             self.log('No %r interface, hoping that the modem connects by itself' % I_NETREG)

-- 
To view, visit https://gerrit.osmocom.org/2471
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I515203a14cf629e789a7f7659d43126898ab4534
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list