[PATCH] libosmo-sccp[master]: SCOC: When sending a CORE/CR, SUA SRC_ADDR == CallingPartyAd...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 4 07:07:40 UTC 2017


Review at  https://gerrit.osmocom.org/2468

SCOC: When sending a CORE/CR, SUA SRC_ADDR == CallingPartyAddress

SUA uses different semantics (source / destination) address, while SCCP
uses Calling/CalledParty. This leads to some confusion.  At least in the
CR/CORE case, the CallingParty equals the SRC_ADDR.

Change-Id: I5a3c27b112148dd539f092cce7618b4f62fde73c
---
M src/sccp_scoc.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/68/2468/1

diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index 5e91ea4..fbb6ef8 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -483,7 +483,7 @@
 		xua_msg_add_u32(xua, SUA_IEI_ROUTE_CTX, conn->inst->route_ctx);
 		xua_msg_add_u32(xua, SUA_IEI_PROTO_CLASS, conn->sccp_class);
 		xua_msg_add_u32(xua, SUA_IEI_SRC_REF, conn->conn_id);
-		xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->called_addr);
+		xua_msg_add_sccp_addr(xua, SUA_IEI_SRC_ADDR, &conn->called_addr);
 		xua_msg_add_u32(xua, SUA_IEI_SEQ_CTRL, 0); /* TODO */
 		/* optional: sequence number (class 3 only) */
 		if (conn->calling_addr.presence)

-- 
To view, visit https://gerrit.osmocom.org/2468
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a3c27b112148dd539f092cce7618b4f62fde73c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list